Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

Feat(browser-emulator): Migrating away from proxies, lots of extra improvements and enabling TS strict mode #104

Merged

Conversation

soundofspace
Copy link
Contributor

No description provided.

Already handled in plugin and this could result in debugger attaching mid logic
…and reflect usage

Type and eslint issues will be fixed in followup commits
Using proxies has a huge amount of flaws, and has proven to be very difficult to fix.
In some cases even possible to fix (proxy != transparent wrapper).
But we dont need the full power of proxies we only need to be able to modify functions.
This commit migrates most proxy logic to the new internalModifyDescriptor logic.
And fixes problems due to TS strict mode
@soundofspace soundofspace force-pushed the feat(browser-emulator)--more-improvements branch from c7e9ef4 to 2813c20 Compare September 3, 2024 08:54
@soundofspace soundofspace changed the title Feat(browser-emulator): Lots of extra improvements and enabling TS strict mode Feat(browser-emulator): Migrating away from proxies, lots of extra improvements and enabling TS strict mode Sep 3, 2024
@soundofspace soundofspace force-pushed the feat(browser-emulator)--more-improvements branch 2 times, most recently from a4bc0b7 to 443f493 Compare September 3, 2024 18:44
@soundofspace soundofspace force-pushed the feat(browser-emulator)--more-improvements branch from 443f493 to 5929b9d Compare September 3, 2024 19:35
@soundofspace soundofspace marked this pull request as ready for review September 3, 2024 20:06
@blakebyrnes blakebyrnes merged commit 0162fe3 into ulixee:main Sep 3, 2024
8 of 9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants