This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 12
Feat(browser-emulator): Migrating away from proxies, lots of extra improvements and enabling TS strict mode #104
Merged
blakebyrnes
merged 16 commits into
ulixee:main
from
soundofspace:feat(browser-emulator)--more-improvements
Sep 3, 2024
Merged
Feat(browser-emulator): Migrating away from proxies, lots of extra improvements and enabling TS strict mode #104
blakebyrnes
merged 16 commits into
ulixee:main
from
soundofspace:feat(browser-emulator)--more-improvements
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakebyrnes
reviewed
Aug 13, 2024
plugins/default-browser-emulator/injected-scripts/_proxyUtils.ts
Outdated
Show resolved
Hide resolved
blakebyrnes
approved these changes
Aug 13, 2024
Already handled in plugin and this could result in debugger attaching mid logic
…and reflect usage Type and eslint issues will be fixed in followup commits
Using proxies has a huge amount of flaws, and has proven to be very difficult to fix. In some cases even possible to fix (proxy != transparent wrapper). But we dont need the full power of proxies we only need to be able to modify functions. This commit migrates most proxy logic to the new internalModifyDescriptor logic. And fixes problems due to TS strict mode
… fix console stack
…+ default fallback config
soundofspace
force-pushed
the
feat(browser-emulator)--more-improvements
branch
from
September 3, 2024 08:54
c7e9ef4
to
2813c20
Compare
soundofspace
changed the title
Feat(browser-emulator): Lots of extra improvements and enabling TS strict mode
Feat(browser-emulator): Migrating away from proxies, lots of extra improvements and enabling TS strict mode
Sep 3, 2024
blakebyrnes
reviewed
Sep 3, 2024
blakebyrnes
reviewed
Sep 3, 2024
plugins/default-browser-emulator/injected-scripts/SharedWorker.prototype.ts
Show resolved
Hide resolved
blakebyrnes
reviewed
Sep 3, 2024
plugins/default-browser-emulator/injected-scripts/UnhandledErrorsAndRejections.ts
Outdated
Show resolved
Hide resolved
blakebyrnes
reviewed
Sep 3, 2024
blakebyrnes
reviewed
Sep 3, 2024
blakebyrnes
reviewed
Sep 3, 2024
blakebyrnes
reviewed
Sep 3, 2024
soundofspace
force-pushed
the
feat(browser-emulator)--more-improvements
branch
2 times, most recently
from
September 3, 2024 18:44
a4bc0b7
to
443f493
Compare
…devine.alpha, fixed upstream
…or defaultPrevented
soundofspace
force-pushed
the
feat(browser-emulator)--more-improvements
branch
from
September 3, 2024 19:35
443f493
to
5929b9d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.